Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: don't panic when resolving / with roots #310

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

sapphi-red
Copy link
Contributor

When calling resolve(base_dir, "/?test.css"), a panic happened.

src/lib.rs Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #310 will not alter performance

Comparing sapphi-red:fix/resolve-slash (691abbb) with main (57fcd6e)

Summary

✅ 3 untouched benchmarks

@Boshen Boshen self-assigned this Nov 18, 2024
@sapphi-red sapphi-red marked this pull request as draft November 18, 2024 09:49
src/tests/roots.rs Outdated Show resolved Hide resolved
@sapphi-red sapphi-red marked this pull request as ready for review November 18, 2024 10:11
@sapphi-red sapphi-red requested a review from Boshen November 18, 2024 10:11
@sapphi-red sapphi-red marked this pull request as draft November 18, 2024 10:12
@sapphi-red sapphi-red marked this pull request as ready for review November 18, 2024 10:39
@Boshen Boshen changed the title fix: don't panic when resolving / fix: don't panic when resolving / with roots Nov 18, 2024
@Boshen Boshen merged commit b7f78c3 into oxc-project:main Nov 18, 2024
18 checks passed
@Boshen Boshen mentioned this pull request Nov 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants