Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: mention extension must start with a . in with_extension #313

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

NicholasLYang
Copy link
Contributor

Noticed that this comment is incorrect. Extensions are required to be prefixed with a .

Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #313 will not alter performance

Comparing NicholasLYang:chore/fix-extension-doc (6b9f407) with main (be378d8)

Summary

✅ 3 untouched benchmarks

@Boshen Boshen changed the title chore: fix comment docs: mention extension must start with a . in with_extension Nov 22, 2024
@Boshen Boshen merged commit 417f534 into oxc-project:main Nov 22, 2024
18 checks passed
@Boshen Boshen mentioned this pull request Nov 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants