Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf: reduce memory allocation by using a thread_local path for path methods #315

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Nov 22, 2024

Learned from parcel 🫶

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 95.77465% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.06%. Comparing base (8ab444b) to head (69512db).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 85.71% 2 Missing ⚠️
src/cache.rs 98.24% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   97.05%   97.06%           
=======================================
  Files          11       11           
  Lines        2412     2454   +42     
=======================================
+ Hits         2341     2382   +41     
- Misses         71       72    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #315 will improve performances by 5.68%

Comparing perf (69512db) with main (8ab444b)

Summary

⚡ 3 improvements

Benchmarks breakdown

Benchmark main perf Change
resolver[multi-thread] 559.5 µs 529.5 µs +5.68%
resolver[resolve from symlinks] 68.3 ms 63.4 ms +7.83%
resolver[single-thread] 521 µs 492.7 µs +5.76%

@Boshen Boshen force-pushed the perf branch 2 times, most recently from da426ec to 779a80a Compare November 22, 2024 03:18
@Boshen Boshen marked this pull request as ready for review November 22, 2024 05:42
@Boshen Boshen merged commit 703c84b into main Nov 22, 2024
21 checks passed
@Boshen Boshen deleted the perf branch November 22, 2024 05:44
@Boshen Boshen mentioned this pull request Nov 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant