Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf: use path.as_os_str().hash() instead of path.hash() #316

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Nov 22, 2024

No description provided.

Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #316 will improve performances by 13.84%

Comparing perf-hash (3cbbbdc) with main (6e45c48)

Summary

⚡ 3 improvements

Benchmarks breakdown

Benchmark main perf-hash Change
resolver[multi-thread] 531.3 µs 466.7 µs +13.84%
resolver[resolve from symlinks] 63 ms 52 ms +21.06%
resolver[single-thread] 491.8 µs 428.5 µs +14.77%

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (6e45c48) to head (3cbbbdc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   97.06%   97.06%           
=======================================
  Files          11       11           
  Lines        2454     2454           
=======================================
  Hits         2382     2382           
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Boshen Boshen changed the title perf: try path.as_os_str().hash() instead of path.hash() perf: use path.as_os_str().hash() instead of path.hash() Nov 22, 2024
@Boshen Boshen marked this pull request as ready for review November 22, 2024 05:57
@Boshen Boshen merged commit 08a19d7 into main Nov 22, 2024
21 checks passed
@Boshen Boshen deleted the perf-hash branch November 22, 2024 05:58
@Boshen Boshen mentioned this pull request Nov 22, 2024
sapphi-red added a commit to sapphi-red/oxc-resolver that referenced this pull request Nov 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant