Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: replace UnsafeCell with RefCell #346

Merged

Conversation

sapphi-red
Copy link
Contributor

There's a slight cost of the runtime borrow check but I guess it's negligible.

Copy link

codspeed-hq bot commented Dec 13, 2024

CodSpeed Performance Report

Merging #346 will not alter performance

Comparing sapphi-red:refactor/replace-unsafecell-with-refcell (caec9d8) with main (0c794f8)

Summary

✅ 3 untouched benchmarks

@Boshen Boshen merged commit 210c923 into oxc-project:main Dec 13, 2024
13 checks passed
@sapphi-red sapphi-red deleted the refactor/replace-unsafecell-with-refcell branch December 13, 2024 09:09
@oxc-bot oxc-bot mentioned this pull request Dec 13, 2024
Boshen added a commit that referenced this pull request Dec 13, 2024
## 🤖 New release
* `oxc_resolver`: 3.0.1 -> 3.0.2 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[3.0.2](oxc_resolver-v3.0.1...oxc_resolver-v3.0.2)
- 2024-12-13

### <!-- 1 -->Bug Fixes

- special case for aliasing `@/` (#348)
- normalize resolved result on Windows for root (#345)

### <!-- 4 -->Refactor

- replace UnsafeCell with RefCell (#346)
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: Boshen <boshenc@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants