api_versions! should make public Semver consts #8322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iximeow
commented
Jun 12, 2025
iximeow
force-pushed
the
ixi/openapi-api-consts
branch
from
8fd226f to
b5f2efb
Compare
they were private, so it was impossible to use version constants defined in a separate API crate. this is the relationship between the DNS server and DNS API types, as one example, so move that explicit `Semver` declaration to one from the `dns-server-api` crate.
iximeow
force-pushed
the
ixi/openapi-api-consts
branch
from
b5f2efb to
0766d03
Compare
davepacheco
approved these changes
Jul 30, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
they were private, so it was impossible to use version constants defined in a separate API crate. this is the relationship between the DNS server and DNS API types, as one example, so move that explicit
Semverdeclaration to one from thedns-server-apicrate.this is the second bit of followup after #8047.