Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix spaces in GitHub discussion code #66

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix spaces in GitHub discussion code #66

merged 1 commit into from
Sep 6, 2024

Conversation

benjaminleonard
Copy link
Collaborator

Fixes #63

@vercel Vercel
Copy link

vercel bot commented Sep 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rfd-site ✅ Ready (Inspect) Visit Preview Sep 6, 2024 3:39pm

iliana
iliana approved these changes Sep 6, 2024
View reviewed changes
Copy link

@iliana iliana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have any way to test this since the Vercel preview doesn't support Google auth, but I imagine this is correct!

@benjaminleonard
Copy link
Collaborator Author

Likewise I borked my local env vars to test GitHub discussions.

...fix env vars
...merge and hope for the best

@benjaminleonard benjaminleonard merged commit b35e57c into main Sep 6, 2024
4 checks passed
@iliana
Copy link

iliana commented Sep 6, 2024 •
edited
Loading

We'll all find out together!

EDIT: Looks good!

@benjaminleonard
Copy link
Collaborator Author

#360noscope

@david-crespo david-crespo deleted the github-comment-prewrap branch September 13, 2024 16:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@iliana iliana iliana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code sections in the discussion viewer are not white-space: pre-wrap
2 participants
@benjaminleonard @iliana