Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add simple retry to rustup commands in rb_sys/mkmf #518

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

ianks
Copy link
Collaborator

@ianks ianks commented Feb 13, 2025

Starting to see some sporadic network failures in rustup downloads. We should retry in these cases.

@ianks ianks requested a review from Copilot February 13, 2025 22:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

gem/lib/rb_sys/mkmf.rb:266

  • Retry logic for the rustup_toolchain_cmd could be simplified using a loop for better readability and maintainability.
	#{rustup_toolchain_cmd} || (sleep 5; #{rustup_toolchain_cmd}) || (sleep 5; #{rustup_toolchain_cmd})

gem/lib/rb_sys/mkmf.rb:267

  • Retry logic for the rustup_default_cmd could be simplified using a loop for better readability and maintainability.
	#{rustup_default_cmd} || (sleep 5; #{rustup_default_cmd}) || (sleep 5; #{rustup_default_cmd})
@ianks
Copy link
Collaborator Author

ianks commented Feb 13, 2025

🙄

@ianks ianks merged commit 7c06004 into main Feb 13, 2025
56 checks passed
@ianks ianks deleted the rustup-retry branch February 13, 2025 22:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant