-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgrade ktlint to 0.42.1 #980
Conversation
The failing test is |
Plugins contain nothing, that's very strange ^^ |
And about mega linter it's my fault... i forced a PR just before taking a plane... i'm kind of ashamed, i'll correct that asap ^^ |
No worries, hope you had a good flight. |
Codecov Report
@@ Coverage Diff @@
## main #980 +/- ##
==========================================
+ Coverage 88.01% 88.04% +0.03%
==========================================
Files 137 137
Lines 3296 3296
==========================================
+ Hits 2901 2902 +1
+ Misses 395 394 -1
Continue to review full report at Codecov.
|
Great !!:) |
@lars-reimann please can you run |
Dropping this in favor of #976, since version 0.42.1 does not support absolute paths. |
Fixes #878 (or leave this issue open for #976, maybe with another title?)
Proposed Changes
I've tested this version locally with JDK 1.8 without issues. Let's see how it goes here. The auto-upgrade from #976 would be a more desirable solution but this is a temporary fix.
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance