Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade ktlint to 0.42.1 #980

Closed
wants to merge 7 commits into from
Closed

Upgrade ktlint to 0.42.1 #980

wants to merge 7 commits into from

Conversation

lars-reimann
Copy link
Contributor

@lars-reimann lars-reimann commented Nov 12, 2021

Fixes #878 (or leave this issue open for #976, maybe with another title?)

Proposed Changes

  1. Upgrade ktlint to 0.42.1

I've tested this version locally with JDK 1.8 without issues. Let's see how it goes here. The auto-upgrade from #976 would be a more desirable solution but this is a temporary fix.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@lars-reimann
Copy link
Contributor Author

The failing test is megalinter/tests/test_megalinter/plugins_test.py::plugins_test::test_load_plugin_success, which failed with a timeout after 60 seconds when running the command npm install jsonlint -g && echo "This is my te... It's probably not caused by the change in this PR.

@nvuillam
Copy link
Member

Plugins contain nothing, that's very strange ^^
I launched again ci jobs

@nvuillam
Copy link
Member

And about mega linter it's my fault... i forced a PR just before taking a plane... i'm kind of ashamed, i'll correct that asap ^^

@lars-reimann
Copy link
Contributor Author

No worries, hope you had a good flight.

@codecov-commenter
Copy link

Codecov Report

Merging #980 (a2bf83a) into main (db10b91) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
+ Coverage   88.01%   88.04%   +0.03%     
==========================================
  Files         137      137              
  Lines        3296     3296              
==========================================
+ Hits         2901     2902       +1     
+ Misses        395      394       -1     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.18% <0.00%> (+2.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db10b91...a2bf83a. Read the comment docs.

@nvuillam
Copy link
Member

Great !!:)

@nvuillam
Copy link
Member

@lars-reimann please can you run bash build.sh ? it will update the dockerfiles

@lars-reimann lars-reimann marked this pull request as draft November 13, 2021 19:36
@lars-reimann
Copy link
Contributor Author

lars-reimann commented Nov 13, 2021

Dropping this in favor of #976, since version 0.42.1 does not support absolute paths.

@lars-reimann lars-reimann deleted the ktlint_0.42.1 branch November 13, 2021 20:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade ktlint (0.40.0 ➜ 0.42.1)
3 participants