-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Initial SDK #2
Initial SDK #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting close!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rapidly release the next portion of this - async handler?
Then the proxy wrapper.
Then I think it's enough for the MVP and showcase!
We can get the above 2 done in this week I'm sure.
|
FYI @Ryouku |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good direction!
Let's fix the remaining stuff, add the README.md and docs on top of the funcs, and we're good for an MVP launch possibly. I'll give it a spin myself near the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment needs to be on top of the actual function, one for each, following Golang styles for comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maaz-munir is this ready for me to do an end-to-end review from a developer's perspective?
This PR contains the SDK for the SERP API.
This is how the UI would look like for someone using the SDK,