Fix: handle bad requests during job creation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UmanShahzad
reviewed
Feb 27, 2024
UmanShahzad
reviewed
Feb 27, 2024
NorbertRadvilovic
force-pushed
the
fix/handle-bad-requests-during-job-creation
branch
from
49cf50c to
2f5b771
Compare
NorbertRadvilovic
force-pushed
the
fix/handle-bad-requests-during-job-creation
branch
from
2f5b771 to
e49334c
Compare
UmanShahzad
approved these changes
Feb 27, 2024
NorbertRadvilovic
deleted the
fix/handle-bad-requests-during-job-creation
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, if user provides invalid data that isn't caught during request validation, then SDK client will hang until timeout is reached.
Since API returns
202 Accepted, status code should be checked when trying toGetJobID().These changes check response status code. In case of an error, response body is included in the error so the user knows what was the issue.