-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
indexDocument not handled when bucket contains > 1k objects #118
Comments
Looking some more into this, our bucket has 1.4k objects, and it looks like by default the s3 client will only return |
Hello @chiefy ! Thanks for this issue and all informations you give me. You are right. I must admit that I didn't though that this project will be used for this kind of huge bucket 😄 . I will work on a quick fix within next days (I have it in mind, need to be tested) and I probably found a solution to allow more results to be served by allowing people to configure the max results limit they want (to avoid looping over all elements and eating all memory !). I will keep you posted. Regards, Oxyno-zeta |
@oxyno-zeta thanks. As it turns out our CI is publishing stuff to s3 without cleaning the bucket beforehand. So I'd say it's an edge-case. |
Do a head request on index document to avoid skipping it on large buckets and do not use the listed files for that anymore. Fix issue #118
Do a head request on index document to avoid skipping it on large buckets and do not use the listed files for that anymore. Fix issue #118
This should be fixed with the 3.1.1 release 🎉 |
Hello, Can you confirm or not that the issue is fixed ? Just to know I need to think about another solution / another fix 😅 . Thanks ! |
This should be ok and now you can manage the pagination if needed. I'm closing this :) |
Do a head request on index document to avoid skipping it on large buckets and do not use the listed files for that anymore. Fix issue oxyno-zeta#118
Describe the bug
indexDocument
doesn't work when folder contains large number of files beforei
To Reproduce
Steps to reproduce the behavior:
index.html
index.html
Expected behavior
Proxy serves
index.html
Screenshots
If applicable, add screenshots to help explain your problem.
Version and platform (please complete the following information):
The text was updated successfully, but these errors were encountered: