fix: Build HTTPS redirect URI when behind LB #156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Feature
When running
s3-proxy
behind a TLS-terminating Load Balancer,s3-proxy
generates ahttp://
value forthe OIDC
redirect_uri
. In HTTPS-only environments (or with secure cookies enabled), this causes the OIDC flow to fail.This PR adds a simple check for the de-facto standard HTTP Header
X-Forwarded-Proto
. If this header is set and has valuehttps
, theGetRequestURI
function will use thehttps
scheme instead ofhttp
.Checklist: