Scoped env #29
Merged
Scoped env #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, any chance to review this PR soon? 😃 |
Hi, sorry for delay, will try to review soon |
p-fedyukovich
requested changes
Jun 25, 2023
FPierre
commented
Jun 26, 2023
|
README updated! |
|
Hi, |
p-fedyukovich
requested changes
Jul 3, 2023
|
Done! I've changed what you ask for |
p-fedyukovich
approved these changes
Jul 3, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'd like to suggest something we're already using in our team: the ability to scope topics and subscriptions.
The aim is to avoid losing messages when several people are working on the same code base (thus subscribing the same handlers to the same subscriptions).
The change introduces a
scopedEnvKeythat prefixes topics and subscriptions. Messages cannot be consumed anymore by any handlers on the team.