Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cursor_control.hpp show_console_cursor - multiple defintions #58

Closed
johughes99 opened this issue May 23, 2020 · 2 comments
Closed

cursor_control.hpp show_console_cursor - multiple defintions #58

johughes99 opened this issue May 23, 2020 · 2 comments

Comments

@johughes99
Copy link

Not really looked into this - as I have a work around. But if you have multiple includes of cursor_control.hpp in separate source files you get the error:

pkcs11_progress.cpp:(.text+0x0): multiple definition of indicators::show_console_cursor(bool)'
pkcs11_ec_ecdsaAttacks.o:pkcs11_ec_ecdsaAttacks.cpp:(.text+0x376): first defined here
`
p-ranav added a commit that referenced this issue May 23, 2020
@p-ranav
Made cursor control/movement functions static inline #58
27f4ad1
@p-ranav
Copy link
Owner

p-ranav commented May 23, 2020 •
edited
Loading

Making these functions static inline should fix the problem. I've pushed the change.

@johughes99
Copy link
Author

Fixed for me.

p-ranav added a commit that referenced this issue May 25, 2020
@p-ranav
Bumped version to v1.9
79dda6d 
* Fixed build issues in g++ caused by missing header #54
* Using terminal width to fill the remainder of the progress bar with empty spaces #56
* Previously this was hard-coded to 10 spaces
* Fixed multiple definitions in helper functions, e.g., cursor control #58
* Implemented option::ProgressType which can be incremental or decremental - Provides an easy interface to implement decremental progress (a regressing bar) #59
* Updated to latest version of termcolor #60
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@p-ranav @johughes99