Fix missing __extenddftf2 symbols for x86-64 targets
#21
+210
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adzialocha
changed the title
__extenddftf2 symbols for x86-64 targets
sandreae
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Oh great, nice detective work 👍
We can remove this line from the READEME:
Lines 126 to 127 in 24519cf
Otherwise all good.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new NDK doesn't link to
libgccanymore, which breaks our libraries since they depended on the symbols fromlibclang_rt.builtins-x86_64-androidlike__extenddftf2. See bbqsrc/cargo-ndk#94 for details.The change works around this by manually linking to the
libclang_rt.builtins-x86_64-androidlibrary in this case.This change pins the required NDK version to
25.2.9519653and fixes an issue running the application for x86-64 targets. I'll update our README.md to address that requirement.