Skip to content

Commit

Permalink
feat: lint files
Browse files Browse the repository at this point in the history
  • Loading branch information
maximedasilva committed Sep 18, 2023
1 parent 08afdf6 commit 31f4a6e
Show file tree
Hide file tree
Showing 21 changed files with 122 additions and 39 deletions.
4 changes: 3 additions & 1 deletion packages/core/lib/colors/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,9 @@ export const parseColor = (color: string = '') => {

for (const parser of COLOR_PARSERS) {
const match = parser.regex.exec(color);
const parsed = match && parser.parse(...match.slice(1) as [string, string, string, string]);
const parsed = match && parser.parse(
...match.slice(1) as [string, string, string, string]
);

if (parsed) {
/* istanbul ignore else: ignored unrecognized format */
Expand Down
18 changes: 5 additions & 13 deletions packages/react/lib/Alert/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ import {
ReactNode,
ComponentPropsWithRef,
ElementType,
ForwardedRef,
ComponentPropsWithoutRef,
ForwardRefExoticComponent,
HTMLAttributes,
} from 'react';
import { classNames } from '@junipero/core';
import { useTimeout } from '@junipero/hooks';
Expand All @@ -25,12 +21,12 @@ declare type AlertRef = {
innerRef: MutableRefObject<any>;
};

declare interface AlertProps extends ComponentPropsWithRef<any> {
declare interface AlertProps extends ComponentPropsWithRef<any>{
animationTimeout?: number;
children?: ReactNode | JSX.Element;
className?: string;
icon?: ReactNode | JSX.Element;
index?: string | number;
index: string | number;
lifespan?: number;
tag?: string | ElementType;
animate?(
Expand All @@ -39,6 +35,8 @@ declare interface AlertProps extends ComponentPropsWithRef<any> {
): ReactNode | JSX.Element;
onDismiss?(index?: string | number): void;
ref?: MutableRefObject<AlertRef | undefined>;
onClick?: (e: Event) => void;
title?: ReactNode | JSX.Element;
}

export declare interface AlertObject{
Expand Down Expand Up @@ -70,7 +68,6 @@ const Alert = forwardRef(({
children,
onClick,
onDismiss,
sss,
...rest
}: AlertProps, ref) => {
const innerRef = useRef();
Expand Down Expand Up @@ -131,12 +128,7 @@ Alert.propTypes = {
]),
lifespan: PropTypes.number,
tag: PropTypes.any, //TODO fixme
title: PropTypes.oneOfType([
PropTypes.node,
PropTypes.string,
PropTypes.func,
PropTypes.object,
]),
title: PropTypes.any,
onDismiss: PropTypes.func,
onClick: PropTypes.func,
};
Expand Down
10 changes: 9 additions & 1 deletion packages/react/lib/Badge/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
import { ComponentPropsWithRef, ElementType, ForwardedRef, MutableRefObject, ReactNode, forwardRef, useImperativeHandle, useRef } from 'react';
import {
ComponentPropsWithRef,
ElementType,
MutableRefObject,
ReactNode,
forwardRef,
useImperativeHandle,
useRef,
} from 'react';
import { classNames } from '@junipero/core';
import PropTypes from 'prop-types';

Expand Down
1 change: 0 additions & 1 deletion packages/react/lib/CodeField/index.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ export const withLabelAndAbstract = () => (
<FieldControl>
<Label className="info" htmlFor="code">One-time code</Label>
<CodeField

id="code"
name="code"
onChange={action('change')}
Expand Down
6 changes: 3 additions & 3 deletions packages/react/lib/DateField/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import Dropdown from '../Dropdown';
import DropdownToggle from '../DropdownToggle';
import DropdownMenu from '../DropdownMenu';
import Calendar from '../Calendar';
import { FixedArray, MockState } from '../utils';
import { FixedArray, ForwardedProps, MockState } from '../utils';

export declare type DateFieldRef = {
dirty: boolean;
Expand Down Expand Up @@ -443,7 +443,7 @@ const DateField = forwardRef(({
</DropdownMenu>
</Dropdown>
);
});
}) as ForwardedProps<DateFieldProps, DateFieldRef>;

DateField.displayName = 'DateField';
DateField.propTypes = {
Expand All @@ -459,7 +459,7 @@ DateField.propTypes = {
valid: PropTypes.bool,
max: PropTypes.instanceOf(Date),
min: PropTypes.instanceOf(Date),
monthNames: PropTypes.array,
monthNames: PropTypes.any,
onBlur: PropTypes.func,
onChange: PropTypes.func,
onFocus: PropTypes.func,
Expand Down
3 changes: 1 addition & 2 deletions packages/react/lib/Draggable/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ const Draggable = forwardRef(({
onDrag: onDrag_,
onDragEnd: onDragEnd_,
});
}) as ForwardedProps<DraggableProps, any>;
}); // TODO fix the forwardedProps problem

Draggable.displayName = 'Draggable';
Draggable.propTypes = {
Expand All @@ -128,5 +128,4 @@ Draggable.propTypes = {
onDragStart: PropTypes.func,
onDragEnd: PropTypes.func,
};

export default Draggable;
3 changes: 2 additions & 1 deletion packages/react/lib/DropdownMenu/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ const DropdownMenu = forwardRef(({
);

return opened || (animate && visible) || apparition === 'css'
? container ? createPortal(content, container as DocumentFragment | Element) : content
? container ? createPortal(content, container as DocumentFragment | Element)
: content
: null;
});

Expand Down
5 changes: 3 additions & 2 deletions packages/react/lib/Droppable/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@ import {
useState,
useEffect,
ComponentPropsWithoutRef,
ComponentPropsWithRef,
} from 'react';
import { classNames } from '@junipero/core';
import PropTypes from 'prop-types';

import { ForwardedProps } from '../utils';

declare interface DroppableProps extends ComponentPropsWithoutRef<any> {
declare interface DroppableProps extends ComponentPropsWithRef<any> {
className?: string;
children?: JSX.Element;
disabled?: boolean;
Expand Down Expand Up @@ -113,7 +114,7 @@ const Droppable = forwardRef(({
onDrop: onDrop_,
onDragOver: onDragOver_,
});
}) as ForwardedProps<DroppableProps, any>;
}); // TODO find a way to put ForwardedProps back

Droppable.displayName = 'Droppable';
Droppable.propTypes = {
Expand Down
10 changes: 9 additions & 1 deletion packages/react/lib/FieldGroup/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
import { ComponentPropsWithRef, ElementType, MutableRefObject, ReactNode, forwardRef, useImperativeHandle, useRef } from 'react';
import {
ComponentPropsWithRef,
ElementType,
MutableRefObject,
ReactNode,
forwardRef,
useImperativeHandle,
useRef,
} from 'react';
import { classNames } from '@junipero/core';
import PropTypes from 'prop-types';

Expand Down
8 changes: 7 additions & 1 deletion packages/react/lib/ListCell/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import { ComponentPropsWithRef, MutableRefObject, forwardRef, useImperativeHandle, useRef } from 'react';
import {
ComponentPropsWithRef,
MutableRefObject,
forwardRef,
useImperativeHandle,
useRef,
} from 'react';

import { ForwardedProps } from '../utils';

Expand Down
9 changes: 8 additions & 1 deletion packages/react/lib/ListColumn/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
import { forwardRef, useLayoutEffect, useImperativeHandle, ReactNode, ComponentPropsWithRef, MutableRefObject } from 'react';
import {
forwardRef,
useLayoutEffect,
useImperativeHandle,
ReactNode,
ComponentPropsWithRef,
MutableRefObject,
} from 'react';
import PropTypes from 'prop-types';

import { useList } from '../hooks';
Expand Down
9 changes: 8 additions & 1 deletion packages/react/lib/ListItem/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
import { ComponentPropsWithRef, MutableRefObject, ReactNode, forwardRef, useImperativeHandle, useRef } from 'react';
import {
ComponentPropsWithRef,
MutableRefObject,
ReactNode,
forwardRef,
useImperativeHandle,
useRef,
} from 'react';
import PropTypes from 'prop-types';

import { ForwardedProps } from '../utils';
Expand Down
8 changes: 7 additions & 1 deletion packages/react/lib/Step/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import { ComponentPropsWithRef, MutableRefObject, ReactNode, forwardRef, useImperativeHandle, useRef } from 'react';
import {
ComponentPropsWithRef,
MutableRefObject,
ReactNode,
forwardRef, useImperativeHandle,
useRef,
} from 'react';
import { classNames } from '@junipero/core';
import PropTypes from 'prop-types';

Expand Down
10 changes: 9 additions & 1 deletion packages/react/lib/Tab/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
import { forwardRef, useRef, useImperativeHandle, ReactNode, MutableRefObject, ComponentPropsWithRef, ElementType } from 'react';
import {
forwardRef,
useRef,
useImperativeHandle,
ReactNode,
MutableRefObject,
ComponentPropsWithRef,
ElementType,
} from 'react';
import PropTypes from 'prop-types';
import { classNames } from '@junipero/core';

Expand Down
10 changes: 9 additions & 1 deletion packages/react/lib/Tag/index.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
import {
ComponentPropsWithRef,
ElementType,
MutableRefObject,
ReactNode,
forwardRef,
useImperativeHandle,
useRef,
} from 'react';
import { classNames } from '@junipero/core';
import PropTypes from 'prop-types';
import { ComponentPropsWithRef, ElementType, MutableRefObject, ReactNode, forwardRef, useImperativeHandle, useRef } from 'react';

import { Remove } from '../icons';
import { ForwardedProps } from '../utils';
Expand Down
8 changes: 7 additions & 1 deletion packages/react/lib/Toasts/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import { ComponentPropsWithRef, forwardRef, MutableRefObject, ReactNode, useImperativeHandle, useRef } from 'react';
import {
ComponentPropsWithRef,
forwardRef,
MutableRefObject,
useImperativeHandle,
useRef,
} from 'react';
import { classNames, omit } from '@junipero/core';
import PropTypes from 'prop-types';

Expand Down
7 changes: 6 additions & 1 deletion packages/react/lib/TouchableZone/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import { ComponentPropsWithRef, ElementType, ReactNode, forwardRef } from 'react';
import {
ComponentPropsWithRef,
ElementType,
ReactNode,
forwardRef,
} from 'react';
import PropTypes from 'prop-types';
import { classNames } from '@junipero/core';

Expand Down
10 changes: 9 additions & 1 deletion packages/react/lib/Transition/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
import { Children, useState, useRef, useCallback, cloneElement, ComponentPropsWithRef, ReactNode } from 'react';
import {
Children,
useState,
useRef,
useCallback,
cloneElement,
ComponentPropsWithRef,
ReactNode,
} from 'react';
import { useTimeout, useLayoutEffectAfterMount } from '@junipero/hooks';
import { classNames } from '@junipero/core';
import PropTypes from 'prop-types';
Expand Down
9 changes: 8 additions & 1 deletion packages/react/lib/hooks.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
import { AlertsContextType, DropdownContextType, FieldContextType, ListContextType, ToastsContextType } from './contexts';
import {
AlertsContextType,
DropdownContextType,
FieldContextType,
ListContextType,
ToastsContextType,
} from './contexts';

export declare const useFieldControl: () => FieldContextType;
export declare const useDropdown: () => DropdownContextType;
export declare const useAlerts: () => AlertsContextType;
Expand Down
6 changes: 4 additions & 2 deletions packages/react/lib/hooks.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ import {
ToastsContextType,
} from './contexts';

export const useFieldControl = () => useContext<FieldContextType>(FieldControlContext);
export const useDropdown = () => useContext<DropdownContextType>(DropdownContext);
export const useFieldControl =
() => useContext<FieldContextType>(FieldControlContext);
export const useDropdown = () =>
useContext<DropdownContextType>(DropdownContext);
export const useAlerts = () => useContext<AlertsContextType>(AlertsContext);
export const useList = () => useContext<ListContextType>(ListContext);
export const useToasts = () => useContext<ToastsContextType>(ToastsContext);
7 changes: 5 additions & 2 deletions packages/react/lib/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ type GrowToSize<T, A extends Array<T>, N extends number> = {

export type FixedArray<T, N extends number> = GrowToSize<T, [], N>;

export declare interface ForwardedProps<T, P> extends ForwardRefExoticComponent<T & React.RefAttributes<P>> {} // TODO move this to core project
// TODO move this to core project
export declare interface ForwardedProps<T, P>
extends ForwardRefExoticComponent<T & React.RefAttributes<P>> {}

export declare type MockState<T> = (state: T, action: any) => T; // TODO move this to core project
// TODO move this to core project
export declare type MockState<T> = (state: T, action: any) => T;

0 comments on commit 31f4a6e

Please # to comment.