Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new geodata decoder is extremely memory efficient and the benchmark result is excellent.
The benchmark result:
The followings are the real statistics(memory usage) come from router component with
log-level
set todebug(0)
. It loadsgeoip:cn
,geoip:private
,geosite:cn
,geosite:private
andgeosite:geolocation-!cn
in both geodata decoders.Memory usage of the new geodata decoder(read geodata files byte by byte):
Memory usage of the original(old) geodata decoder(read geodata files at once entirely):