Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove obsolete implicit attribute _cc_toolchain #5062

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

katre
Copy link
Contributor

@katre katre commented Dec 13, 2024

CC toolchains are gathered from the line:

toolchains = use_cc_toolchains(),

CC toolchains are gathered from the line:
```
toolchains = use_cc_toolchains(),
```


Signed-off-by: John Cater <jcater@google.com>
@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Dec 13, 2024
@katre
Copy link
Contributor Author

katre commented Dec 17, 2024

@smolkaj Can you also review this (once tests pass)?

Copy link
Member

@smolkaj smolkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smolkaj smolkaj added this pull request to the merge queue Dec 18, 2024
Merged via the queue into p4lang:main with commit 8062920 Dec 18, 2024
19 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants