-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update Node.js support to 18-20 from 12-16, dependencies, documentation, some practices #19
Conversation
…ent in comments, names
…es lockfileVersion to 2 from 1)
0a47f85
to
7fc14d8
Compare
@josebolos Perhaps I could have forgone retaining Node 14 support, following @aarongoldenthal's lead in pa11y/pa11y#664, since it has passed EOL, even if it still passes in CI. Node 16 also reached EOL on September 11th 2023. What do you think? |
Agreed! I think that we should only support currently supported LTS versions, so I would remove support for anything that is not Node 18 or 20 from every repo. |
@josebolos Done for this repo, noted for others! I've also removed the advice to use npm 8+ since npm 8 comes with Node 18. |
Removed section and added issue for discussion to pa11y/org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR if it passes review will require a major version update. I've mentioned "version 4" in a couple of places in anticipation. It:
14-2018-20 from 12-16More detail in commit log and will summarise here:
fakeServer
grunt ci
; we could consider removing Grunt completely in a future PRpush
will now trigger on bothmaster
andmain
in preparation for renaming the default branch