Revert changes to test for flakiness

packbackbooks · Sep 13, 2024 · 6cba723 · 6cba723
1 parent 635e628
commit 6cba723
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 15 deletions.
diff --git a/lib/command/run-rerun.js b/lib/command/run-rerun.js
@@ -17,6 +17,10 @@ module.exports = async function (test, options) {
   const testRoot = getTestRoot(configFile)
   createOutputDir(config, testRoot)
 
+  function processError(err) {
+    printError(err)
+    process.exit(1)
+  }
   const codecept = new Codecept(config, options)
 
   try {

diff --git a/lib/rerun.js b/lib/rerun.js
@@ -70,7 +70,6 @@ class CodeceptRerunner extends BaseCodecept {
       await this.runTests(test);
     } catch (e) {
       output.error(e.stack);
-      throw e;
     } finally {
       event.emit(event.all.result, this);
       event.emit(event.all.after, this);

diff --git a/test/runner/run_rerun_test.js b/test/runner/run_rerun_test.js
@@ -96,18 +96,4 @@ describe('run-rerun command', () => {
       },
     )
   })
-
-  it('should throw exit code 1 if all tests were supposed to pass', (done) => {
-    exec(
-      `FAIL_ATTEMPT=0  ${codecept_run_config('codecept.conf.pass_all_test.js', '@RunRerun - fail second test')} --debug`,
-      (err, stdout) => {
-        expect(stdout).toContain('Process run 1 of max 3, success runs 1/3')
-        expect(stdout).toContain('Fail run 2 of max 3, success runs 1/3')
-        expect(stdout).toContain('Process run 3 of max 3, success runs 2/3')
-        expect(stdout).toContain('Flaky tests detected!')
-        expect(err.code).toBe(1)
-        done()
-      },
-    )
-  })
 })