feat: add asChild prop #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joaom00
commented
May 15, 2023
cmdk/src/index.tsx
Outdated
Comment on lines
593
to
608
| {props.asChild ? ( | ||
| <Slottable> | ||
| {React.isValidElement(children) && | ||
| React.cloneElement( | ||
| children, | ||
| undefined, | ||
| <StoreContext.Provider value={store}> | ||
| <CommandContext.Provider value={context}>{children.props.children}</CommandContext.Provider> | ||
| </StoreContext.Provider>, | ||
| )} | ||
| </Slottable> | ||
| ) : ( | ||
| <StoreContext.Provider value={store}> | ||
| <CommandContext.Provider value={context}>{children}</CommandContext.Provider> | ||
| </StoreContext.Provider> | ||
| )} |
There was a problem hiding this comment.
I had to do this in some components because Slot does not support when children are nested. For example:
If we have this component:
const Button = () => (
<Slot>
<div>
{children}
</div>
</Slot>
)and using like
<Button asChild>
<a>
Button
</a>
</Button>will result in
<div>
<a>
Button
</a>
</div>instead of
<a>
<div>
Button
</div>
</a>
pacocoursey
reviewed
Aug 14, 2023
cmdk/src/index.tsx
Outdated
Comment on lines
1038
to
1049
| const Primitive = NODES.reduce((primitive, node) => { | ||
| const Node = React.forwardRef((props: PrimitivePropsWithRef<typeof node>, forwardedRef: any) => { | ||
| const { asChild, ...primitiveProps } = props | ||
| const Comp: any = asChild ? Slot : node | ||
|
|
||
| return <Comp {...primitiveProps} ref={forwardedRef} /> | ||
| }) | ||
|
|
||
| Node.displayName = `Primitive.${node}` | ||
|
|
||
| return { ...primitive, [node]: Node } | ||
| }, {} as Primitives) |
There was a problem hiding this comment.
Let's bring in the @radix-ui/react-primitive package for this behavior instead, for better package de-duplication.
|
@pacocoursey anything blocking this PR? I'm interested in having #156 fixed. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
asChildprop to all componentsCloses #98