Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(pages/index): remove unnecessary fragment #86

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

nicholaschiang
Copy link
Contributor

@nicholaschiang nicholaschiang commented Feb 12, 2023

This PR removes a seemingly unnecessary React <Fragment> from the index page definition. If this was an intentional code style change, then I'm all for it—though I would be curious as to why it was made. In general, I think less code is pretty much always better. :)

Also, kudos for an amazing library @pacocoursey @raunofreiberg! This is pretty awesome. ❤️‍🔥

This commit removes a seemingly unnecessary React `<Fragment>` from the
index page definition. In general, I think less code is better. :)
@vercel
Copy link

vercel bot commented Feb 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 12, 2023 at 5:47AM (UTC)

Copy link
Owner

@pacocoursey pacocoursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason for it, but not much reason to remove it either.

@pacocoursey pacocoursey merged commit fe3f790 into pacocoursey:main Feb 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants