Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

Record:getResourceRecord() doesn't handle priority? #112

Closed
ericb-summit opened this issue Jul 5, 2021 · 4 comments · Fixed by #115
Closed

Record:getResourceRecord() doesn't handle priority? #112

ericb-summit opened this issue Jul 5, 2021 · 4 comments · Fixed by #115
Assignees
Labels

Comments

@ericb-summit
Copy link

I am trying to use this tool, migrated the data from our legacy system, etc... and I'm running into several issues that make me think maybe I shouldn't be using HEAD master or main (or whatever the default branch is called this week).

For one, the generated named.conf entries (see config_master.blade.php) have duplicate following section, and BIND ceremoniously refuses to even load with that:

allow-query {
    any;
};

Then, in generating MX records, or basically, anything with a priority, I see Record:getResourceRecord() doesn't even use the priority field of the record at all. Seriously, how is this possible? Without a prio you can't do MX, or NAPTR, or SRV, etc etc

One last thing, ProBindPushDnsZones.php does indeed push the zones but it doesn't restart BIND, to actually reload the named.conf and zonefiles.

I can provide examples, but this is all kind of obvious. So obvious, I am wondering, am I in the wrong branch?

Thank you for your time.

@ericb-summit
Copy link
Author

Also, zone.blade.php or some element in laravel escapes characters like double quotes, which are valid, and necessary for some NAPTR records.

@pacoorozco pacoorozco self-assigned this Jul 8, 2021
@pacoorozco pacoorozco added the bug label Jul 8, 2021
@pacoorozco
Copy link
Owner

It's going to be fixed on v0.12.2.

@ericb-summit
Copy link
Author

Hi Paco, I ran into a number of other issues that I fixed. Should I add to this issue, or just open a PR?

@pacoorozco
Copy link
Owner

pacoorozco commented Jul 12, 2021 via email

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants