Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Wonder Room #3394

Closed
wants to merge 3 commits into from
Closed

Conversation

Fontbane
Copy link
Contributor

@Fontbane Fontbane commented Aug 7, 2024

What are the changes?

  • Implements the move Wonder Room, which swaps Defense and Sp. Def stats of all battlers for 5 turns

Why am I doing these changes?

  • I just think it's neat
  • Could be used for challenges, mystery encounters, or in the endless rework

What did change?

  • Added Wonder Room arena tag type
  • Added a check in getBattlerStat for this, which swaps the stats if needed
  • Added localization entries for Wonder Room's arena flyout and tag add/remove messages
  • Changed from Unimplemented to Partial, in case I forgot something

Screenshots/Videos

Used Body Press without Wonder Room (going off Chansey's tiny defense stat of 7)
Screenshot_828

Using Wonder Room
Screenshot_829

Used Body Press with Wonder Room (going off Chansey's bigger special defense stat of 17)
Screenshot_830

How to test the changes?

  • Test this out with a mon that has a sizable disparity in Def and SpDef stats, or Atk and SpAtk versus a balanced opponent
  • Body Press and Psyshock may be useful in testing
  • I'll write a unit test if asked

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Fontbane Fontbane changed the base branch from main to beta August 7, 2024 02:46
@Madmadness65 Madmadness65 added the Move Affects a move label Aug 7, 2024
@torranx
Copy link
Contributor

torranx commented Aug 7, 2024

Linking because of relevance: #2699

@xsn34kzx
Copy link
Collaborator

xsn34kzx commented Aug 7, 2024

Linking because of relevance: #2699

I would say to put a pin in this until I can finish up this PR since this would allow the swapping process to be way easier (with examples from moves like Speed Swap when I get around to it) without having to manually swap every time out of necessity.

@SangaraSorama SangaraSorama added the Localization Provides or updates translation efforts label Aug 26, 2024
@flx-sta flx-sta marked this pull request as draft September 5, 2024 04:29
@Adri1 Adri1 removed the Localization Provides or updates translation efforts label Sep 29, 2024
@Fontbane
Copy link
Contributor Author

Fontbane commented Nov 8, 2024

Someone else can take care of this, has to be reworked anyway

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Move Affects a move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants