[Move] Spectral Thief Full Implementation

[geeilhan]

What are the changes the user will see?

Spectral Thief now steals the stat changes correctly.

Why am I making these changes?

(#3503)

What are the changes from a developer perspective?

Added a SpectralThiefAttr which extends a new StatChangeBeforeDmgCalcAttr that applies Stat Stage changes before damage calculation.

Ability Attributes such as Contrary and Simple are applied correctly since the stat changes happen through the StatStageChangePhase.

I would also like a message to pop up if stats are stolen correctly. I added the english text here public/locales/en/move-trigger.json. Do I need to push it for the other languages too?

target.scene.queueMessage(i18next.t("moveTriggers:stolePositiveStatChanges", { pokemonName: getPokemonNameWithAffix(user), targetName: getPokemonNameWithAffix(target) }));

https://github.com/geeilhan/pokerogueFork/blob/590f66e09f61f2163534d265d21b84048175cfe2/src/data/move.ts#L4367-L4368

Link to pokerogue-locales PR

Screenshots/Videos

Before Spectral Thief implementation:

spectral-thief-implementation-before.webm

After Spectral Thief implementation:

spectral-thief-implementation-after.webm

How to test the changes?

added automated tests for

• Basic Use
• Substitute Interaction
• Protect Interaction
• Clear Body, White Smoke and Hyper Cutter Interaction
• Simple Interaction
• Contrary Interaction
• Check if Dmg is calculated after stat changes

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[geeilhan]

How do i solve this conflict? Running git submodule update --recursive does not work.

[damocleas]

How do i solve this conflict? Running git submodule update --recursive does not work.

git submodule update --progress --init --recursive --force --remote
should be the one that updates locales

[geeilhan]

git submodule update --progress --init --recursive --force --remote

thanks!

Unfortunately that did not resolve it :/. Is it because I have this?
globalScene.queueMessage(i18next.t("moveTriggers:stealPositiveStats", { pokemonName: getPokemonNameWithAffix(user), targetName: getPokemonNameWithAffix(target) }));

[SirzBenjie]

I believe I've figured out the fix.

I have a merge PR ready I did via command line.

[SirzBenjie]

The associated locales PR is here: pagefaultgames/pokerogue-locales#52 (It's marked as a draft)

[SirzBenjie]

Being able to approve this PR is the entire motivation behind me contributing so heavily to the project recently. (I jest)

[DayKev]

Once the locales PR is merged the locales can be updated in this PR and then it can be merged. 👍

[SirzBenjie]

Once the locales PR is merged the locales can be updated in this PR and then it can be merged. 👍

Wait does the PR have to be updated? It should just work right?

Or it will cause a conflict cause of submodules

[DayKev]

The submodule will need to be updated, without doing so the i18n keys won't exist and then it'll display the raw i18n keys in-game.

[SirzBenjie]

the locales can be updated in this PR

This is what I meant. Is the locales submodule not merged independently of the PRs that need them? It really should be.

[DayKev]

Even if the locales were to be updated separately we'd still want to wait until it's ready before merging this PR or there'd be broken text in the game.

[SirzBenjie]

Even if the locales were to be updated separately we'd still want to wait until it's ready before merging this PR or there'd be broken text in the game.

Yup yup, entirely agree :) we def don't put this in until the locales is in the beta branch. I was just unclear on how the locales got into the beta branch.

Thought there was something that needed to be changed in this PR, as in a commit to be added.