[UI/UX] Change label for music settings #5053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Music settings options changed from "Consistent/Mixed" to "Gen V + PMD/All Gens".
Why am I making these changes?
The existing labels don't tell the user what they do, leading to confusion.
What are the changes from a developer perspective?
New i18n keys created in
settings.json
:musicGenFive
andmusicAllGens
.Labels changed in
settings.ts
to use the new keys.Screenshots/Videos
Checklist
beta
as my base branchAre there any localization additions or changes? If so: