Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[UI/UX] Change label for music settings #5053

Merged
merged 4 commits into from
Dec 31, 2024

Conversation

DayKev
Copy link
Collaborator

@DayKev DayKev commented Dec 29, 2024

What are the changes the user will see?

Music settings options changed from "Consistent/Mixed" to "Gen V + PMD/All Gens".

Why am I making these changes?

The existing labels don't tell the user what they do, leading to confusion.

What are the changes from a developer perspective?

New i18n keys created in settings.json: musicGenFive and musicAllGens.
Labels changed in settings.ts to use the new keys.

Screenshots/Videos

image

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Have I provided screenshots/videos of the changes (if applicable)?

Are there any localization additions or changes? If so:

Changes from "Consistent/Mixed" to "Gen 5/All Generations"
@DayKev DayKev added UI/UX User interface/-experience related Awaiting Locales This PR makes changes to existing locales and requires further review labels Dec 29, 2024
@DayKev DayKev requested a review from a team as a code owner December 29, 2024 08:13
damocleas
damocleas previously approved these changes Dec 29, 2024
@Adri1
Copy link
Contributor

Adri1 commented Dec 30, 2024

As the related locale PR removes a key in the processes, the "Awaiting Locales" tag can't be applied here, so I remove it

@Adri1 Adri1 removed the Awaiting Locales This PR makes changes to existing locales and requires further review label Dec 30, 2024
@DayKev
Copy link
Collaborator Author

DayKev commented Dec 30, 2024

As the related locale PR removes a key in the processes, the "Awaiting Locales" tag can't be applied here, so I remove it

The locales PR needs to be merged first so I can update the submodule in this PR. This PR can't be merged before the locales PR.

Madmadness65
Madmadness65 previously approved these changes Dec 30, 2024
@DayKev DayKev dismissed stale reviews from Madmadness65 and damocleas via 30e3d01 December 31, 2024 02:54
@DayKev DayKev merged commit 1b6374f into pagefaultgames:beta Dec 31, 2024
13 checks passed
@DayKev DayKev deleted the change-music-settings-label branch December 31, 2024 02:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants