Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Hotfix] Prevent Keldeo from changing forms in Daily Run #5060

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

DayKev
Copy link
Collaborator

@DayKev DayKev commented Dec 31, 2024

What are the changes the user will see?

Keldeo will no longer be able to change forms in Daily Run mode, preventing a crash.

Why am I making these changes?

The game crashes if the player has Keldeo in their starting party in Daily Run mode.

What are the changes from a developer perspective?

A condition was added to Keldeo's form changes that checks if the mode is Daily Run and prevents the form change if so.

Checklist

  • [ ] I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?

@DayKev DayKev added the P1 Bug Major. Game crashing move/ability/interaction label Dec 31, 2024
@DayKev DayKev requested a review from a team as a code owner December 31, 2024 04:08
@Snailman11
Copy link
Collaborator

Link to Discord's Bug Report (Daily stuck, Keldeo Form Change Screen)
https://discord.com/channels/1125469663833370665/1323444110149029998

@DayKev DayKev merged commit 14902cd into pagefaultgames:main Dec 31, 2024
14 checks passed
@DayKev DayKev deleted the hotfix/disable-keldeo-form-daily branch December 31, 2024 04:20
IBBCalc added a commit to IBBCalc/Pathing-Tool that referenced this pull request Dec 31, 2024
[Hotfix] Prevent Keldeo from changing forms in Daily Run (pagefaultgames#5060)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
P1 Bug Major. Game crashing move/ability/interaction
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants