Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Hotfix] Fix year of the snake event banner #5202

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Fontbane
Copy link
Contributor

What are the changes the user will see?

Fixes the event banner not appearing

Why am I making these changes?

What are the changes from a developer perspective?

Adds the array of available languages for the banner, which was empty initially so it wouldn’t crash while we waited for the banners to be made. From now on we’ll probably use placeholders instead.

Screenshots/Videos

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Fontbane Fontbane requested a review from a team as a code owner January 29, 2025 00:05
@DayKev DayKev added Miscellaneous Changes that don't fit under any other label P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. labels Jan 29, 2025
@Madmadness65 Madmadness65 merged commit 9fb9bb7 into pagefaultgames:main Jan 29, 2025
14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Miscellaneous Changes that don't fit under any other label P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants