-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Bug] Fix Clobbopus being unable to evolve before level 35 #5312
base: beta
Are you sure you want to change the base?
Conversation
Being able to luck into Grapploct super early is not desirable behavior |
If this is how it works in mainline, I see absolutely no issue with this implementation |
How is that any different from lucking into an item evolution? This restriction is completely arbitrary and only present because Taunt used to be (N). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise, looks good.
I'll abstain from balance considerations in my approval.
Can you alter the PR to include every other mon where this applies as well? This is most visible on Clobbopus because Taunt is a TM, but technically all of these could get their moves earlier through fuse tutoring. I don't think splitting them all into different PRs is warranted when it's the same effective discussion every time. It should also be noted that weirdly, Bonsly and Mime Jr. do evolve at any level despite not getting their evo moves at level 1, so I don't think this was ever a hard rule to begin with. |
I'm more of a fan of restricting that slightly so the first 10 waves aren't instantly evolved but otherwise idc, also the above, should just try to catch them all if there's more |
What are the changes the user will see?
Why am I making these changes?
What are the changes from a developer perspective?
SpeciesWildEvolutionDelay.LONG
Screenshots/Videos
How to test the changes?
ITEM_REWARD_OVERRIDE: [{ "name": "TM_GREAT", type: Moves.TAUNT }]
This will give you the TM for Taunt in your rewards. Start with Clobbopus and it should evolve by wave 5.
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: