Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Ability] Flower Veil implementation #5327

Draft
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

SirzBenjie
Copy link
Member

@SirzBenjie SirzBenjie commented Feb 14, 2025

What are the changes the user will see?

Flower Veil works as it does on Cartridge, and is no longer marked (N).

Why am I making these changes?

I was commissioned by @Blitz425

What are the changes from a developer perspective?

TODO

Screenshots/Videos

TODO

How to test the changes?

TODO

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • [ ] Has a locales PR been created on the locales repo?
    • [ ] If so, please leave a link to it here:
  • [ ] Has the translation team been contacted for proofreading/translation?

@Madmadness65 Madmadness65 changed the title [Move] Flower Veil implementation [Ability] Flower Veil implementation Feb 15, 2025
@Madmadness65 Madmadness65 added the Ability Affects an ability label Feb 15, 2025
@SirzBenjie SirzBenjie force-pushed the flower-veil branch 2 times, most recently from d443de1 to 428eb98 Compare February 22, 2025 23:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Ability Affects an ability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants