Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Hotfix] v1.6.4: Fix crash involving female Pyroar fusions with exp sprites #5331

Merged
merged 3 commits into from
Feb 15, 2025

Conversation

Fontbane
Copy link
Contributor

What are the changes the user will see?

  • Fixes a crash where the game would freeze when encountering a fusion with female Pyroar as the secondary mon- specifically when experimental sprites are on.
    image

Why am I making these changes?

What are the changes from a developer perspective?

  • The game now does not attempt to apply a fusion palette if one fails to generate.

Screenshots/Videos

image

How to test the changes?

Take attached save to wave xxx3, where you will encounter a Frosmoth/Pyroar fusion. After changing file extension ofc.
sessionData1_Manurh9.txt

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Fontbane Fontbane requested a review from a team as a code owner February 15, 2025 02:24
@Madmadness65 Madmadness65 added the P1 Bug Major. Game crashing move/ability/interaction label Feb 15, 2025
Madmadness65
Madmadness65 previously approved these changes Feb 15, 2025
@DayKev
Copy link
Collaborator

DayKev commented Feb 15, 2025

Huh, it looks like the submodule didn't update correctly?

Copy link
Collaborator

@DayKev DayKev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked this time.

@DayKev DayKev merged commit 7b9d1d6 into pagefaultgames:main Feb 15, 2025
14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
P1 Bug Major. Game crashing move/ability/interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants