Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Sprite] Fix Impidimp front, Arctozolt back variants #5342

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

Fontbane
Copy link
Contributor

What are the changes the user will see?

  • Fixes Arctozolt back variants not loading if the user has experimental sprites turned on for some reason
  • Impidimp doesn't have an obvious problem atm, but better safe than sorry
  • Fixes random different colored pixel on Arctozolt back (static, T0/T1)

Why am I making these changes?

What are the changes from a developer perspective?

  • Impidimp static front and Arctozolt static back variants now use shader json instead of custom sprites

Screenshots/Videos

Impidimp static front variants using shader json:
image
image
old sprites:
image
image

Arctozolt back exp before
image
image
After:
image
image

static before (separate sprites, weird pixel)
image
image
image
image
after (shader, fixed weird pixel)
image
image
image
image

How to test the changes?

Turn on the "dex for devs" setting and check in consistent and exp

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Fontbane Fontbane requested a review from a team as a code owner February 16, 2025 02:32
@Fontbane Fontbane added Sprite/Animation For issues/PRs related to graphics P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. labels Feb 16, 2025
@SirzBenjie SirzBenjie merged commit c7ee017 into pagefaultgames:beta Feb 18, 2025
13 checks passed
Jimmybald1 pushed a commit to IBBCalc/Pathing-Tool that referenced this pull request Feb 27, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. Sprite/Animation For issues/PRs related to graphics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants