Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Sprite] Convert some variant pngs to shader json #5346

Draft
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

Unicornpowerstar
Copy link
Contributor

What are the changes the user will see?

Why am I making these changes?

What are the changes from a developer perspective?

Screenshots/Videos

How to test the changes?

Checklist

  • I'm using beta as my base branch
    - [ ] There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
    - [ ] Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    - [ ] Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:
-~ [ ] Has a locales PR been created on the locales repo?~
- [ ] If so, please leave a link to it here:
- [ ] Has the translation team been contacted for proofreading/translation?

removal of pngs into variant json
@Unicornpowerstar Unicornpowerstar self-assigned this Feb 16, 2025
@Unicornpowerstar Unicornpowerstar added the Sprite/Animation For issues/PRs related to graphics label Feb 16, 2025
@Fontbane Fontbane changed the title [Sprite] Removal of pngs into Json none exp set. [Sprite] Convert some variant pngs to shader json Feb 18, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Sprite/Animation For issues/PRs related to graphics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sprite] Documenting Fix for variant desync between static and exp loading issue
1 participant