Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Validate and ideally repace uses of mem::transmute #52

Closed
paholg opened this issue Aug 12, 2018 · 0 comments
Closed

Validate and ideally repace uses of mem::transmute #52

paholg opened this issue Aug 12, 2018 · 0 comments
Labels
help wanted

Comments

@paholg
Copy link
Owner

paholg commented Aug 12, 2018

There are two places in the make_units! macro where mem::transmute is used; for implementing Index and IndexMut. Both require going from &V to &$System<V, U> for some U.

I think that the current use should be safe, but would like external validation. It would also be nice to replace it with something less dangerous.
@paholg paholg changed the title Validate and ideally repace uses of unsafe transmute Validate and ideally repace uses of mem::transmute Aug 12, 2018
adeschamps added a commit to adeschamps/dimensioned that referenced this issue Aug 14, 2018
@adeschamps
Replace transmutes with pointer casts (paholg#52)
90e326a
paholg added a commit that referenced this issue Aug 15, 2018
@paholg
Merge pull request #57 from adeschamps/remove-transmute
4e3ff75 
Replace transmutes with pointer casts (#52)
@paholg paholg closed this as completed Aug 15, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paholg