[Fix] #353: Evaluate Buildscan Directly When Root is Evaluated #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarcaur
changed the title
|
Note for the reviewers: I wrote the test, observed the failing behavior, and then I applied the fix. So this definitely exhibits and fixes the behavior described in #353 |
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
carterkozak
reviewed
Mar 21, 2022
carterkozak
reviewed
Mar 21, 2022
src/groovy/groovy/com/palantir/gradle/gitversion/BuildScanPluginInterop.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: Carter Kozak <ckozak@ckozak.net>
carterkozak
approved these changes
Apr 7, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Issue is described at length: #353
After this PR
Usages of
git-versionon submodules no longer errors out.Possible downsides?
It's possible that this check was meant to fail when a user does not apply the plugin at the root, but as it stands all it does is runtime check that our code properly calls out to a project's root and then applies it. So an alternative fix is to hard error when this is called in submodules. However, fixing that "bug" is a breaking change.