Skip to content

Format type annotation as part of the type, not part of the modifiers list #805

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mernst
Copy link

@mernst mernst commented Oct 15, 2022

This pull request cherry-picks commit google/google-java-format@865cff01, "Format type annotation as part of the type, not part of the modifiers list" from google-java-format. It includes a few other changes that are needed by that commit, or that reduce the size of the diffs against google-java-format.

There are some changes to testdata/*.output files -- that is, to the expected output of the formatter. These relate to formatting of annotations and are due to changes in google-java-format.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/palantir-java-format, @mernst! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@changelog-app
Copy link

changelog-app bot commented Oct 15, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Format type annotation as part of the type, not part of the modifiers list

This pull request cherry-picks commit google/google-java-format@865cff01, "Format type annotation as part of the type, not part of the modifiers list" from google-java-format. It includes a few other changes that are needed by that commit, or that reduce the size of the diffs against google-java-format.

There are some changes to testdata/*.output files -- that is, to the expected output of the formatter. These relate to formatting of annotations and are due to changes in google-java-format.

Check the box to generate changelog(s)

  • Generate changelog entry

@mernst
Copy link
Author

mernst commented Dec 1, 2022

Ping.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants