feat: add rector rule for deprecated GDToolkit #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timohuisman
force-pushed
the
feature/3416757-GDToolkit
branch
from
a7bcc4a to
12d8a10
Compare
|
The tests are failing because of #290 |
bbrala
requested changes
Jan 28, 2024
bbrala
force-pushed
the
feature/3416757-GDToolkit
branch
from
12d8a10 to
c8d751e
Compare
|
Wonder if renaming ::resource is even something we should do. I mean, its a protected var, you might use it in an extending class but you could argue that is not common at all. When looking at contrib i see no instances of that. So perhaps just remove the property fetch and only do the public API. |
…roperties in 10.2
…s protected anyways.
bbrala
force-pushed
the
feature/3416757-GDToolkit
branch
from
1829c34 to
5f08443
Compare
bbrala
approved these changes
Mar 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add rector rule for deprecated GDToolkit resource methods and properties in 10.2
Description
GDToolkit::setResource(), GDToolkit::getResource() and GDToolkit::resource are deprecated.
GDToolkit has been updated to use the GD extension classed object \GdImage instead of a generic resource.
Todo
RenamePropertyRector, but I'm not sure where to start.To Test
Drupal.org issue
https://www.drupal.org/project/rector/issues/3416757
https://www.drupal.org/node/3265963