Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix checking for pytest-xprocess #593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgorny
Copy link

@mgorny mgorny commented Oct 15, 2024

Fix conftest not to require pytest_xprocess module. This module has been removed back in 2021, and it is missing since pytest-xprocess 0.19.0. Checking for just xprocess is fine, and makes all tests run again.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

Fix conftest not to require `pytest_xprocess` module.  This module
has been removed back in 2021, and it is missing since pytest-xprocess
0.19.0.  Checking for just `xprocess` is fine, and makes all tests run
again.

fixes pallets-eco#592
@mgorny
Copy link
Author

mgorny commented Oct 15, 2024

Ok, to get things in order: none of the CI failures are technically introduced by this PR.

pre-commit finds style issues in code that wasn't touched here. CI fails because of some existing redis-related failures; I suspect either these tests didn't run before, or something changed in the meantime.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

pytest-xprocess is not detected correctly since 0.19.0
1 participant