Added missing Korean translations. #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added the missing Korean translations, though I have to ask, the translation for the string, ```"Choices cannot be None."``` is a bit tricky, due to `None` being a Python programming term, and there is no direct translation for it (the same applies for null). Korean programmers will most likely understand if I refer to it as `None`, so I left it that way. If ```"Choices cannot be None. "``` is asking the user that an empty field is invalid, the transaltion ```"선택값이 없을 수 없습니다."``` (meaning that ) is more appropriate.
|
Hi. Thank you for you contribution. I cannot really help to review korean. Is this patch OK to merge or do you prefer to be sure of your translation first? |
|
Yes, I think the translation is good as it is. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the missing Korean translations, though I have to ask, the translation for the string,
"Choices cannot be None."is a bit tricky, due to
Nonebeing a Python programming term, and there is no direct translation for it (the same applies for null). Korean programmers will most likely understand if I refer to it asNone, so I left it that way.If
"Choices cannot be None. "is asking the user that an empty field is invalid, the transaltion"선택 값이 없을 수 없습니다."(meaning 'the choice cannot be empty') is more appropriate.