Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix typing on command and group decorators #2256

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

Jonxslays
Copy link
Contributor

This PR adds generics to the typing.Callable type hint inside the command and group decorators.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism linked an issue Apr 24, 2022 that may be closed by this pull request
@davidism davidism added this to the 8.1.3 milestone Apr 24, 2022
@davidism davidism merged commit afdfb12 into pallets:8.1.x Apr 26, 2022
@Jonxslays Jonxslays deleted the patch/typing-fix branch April 26, 2022 14:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

command and group decorators are untyped on strict
2 participants