Skip to content

Allow self as an argument to url_for #5264

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Allow self as an argument to url_for #5264

merged 1 commit into from
Sep 30, 2023

Conversation

pgjones
Copy link
Member

@pgjones pgjones commented Sep 24, 2023

This makes the Flask.url_for self argument positional only (Flask supports Python 3.8+) thereby restoring the ability to pass self as a value argument to url_for.

Closes #5258

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

This makes the Flask.url_for self argument positional only (Flask
supports Python 3.8+) thereby restoring the ability to pass self as a
value argument to url_for.
@pallets pallets deleted a comment from ByteJoseph Sep 29, 2023
@pgjones pgjones added this to the 3.0.0 milestone Sep 30, 2023
@pgjones pgjones merged commit 438edcd into pallets:main Sep 30, 2023
@pgjones pgjones deleted the url_for branch September 30, 2023 14:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Flask.url_for() got multiple values for argument 'self'
1 participant