Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pass context to test when using select #1762

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

rgroothuijsen
Copy link
Contributor

This bugfix allows pass_context to be used by tests in combination with select, which was previously failing because select did not pass the context object, and thus the context would remain None.

Fixes #1624.

Regarding the request for updating CHANGES.rst: should I add a new version number (i.e. 3.1.3) to the document for this bugfix? I'm assuming that 3.1.x is the correct target branch for this PR, but I wasn't entirely sure.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 3.1.5 milestone Dec 20, 2024
@davidism davidism merged commit 028f61d into pallets:stable Dec 20, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants