Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use asyncio.run in Template.render #1952

Merged
merged 1 commit into from
May 11, 2024
Merged

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Apr 7, 2024

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@graingert graingert marked this pull request as ready for review April 7, 2024 09:35
@graingert graingert changed the title use asyncio.run use asyncio.run in Template.render Apr 7, 2024
@davidism davidism added the async label May 11, 2024
@davidism davidism added this to the 3.1.5 milestone May 11, 2024
@davidism davidism changed the base branch from main to 3.1.x May 11, 2024 20:43
@davidism davidism merged commit 079e831 into pallets:3.1.x May 11, 2024
12 checks passed
@graingert graingert deleted the use-asyncio-run branch May 11, 2024 21:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template.render changelog is documented as using asyncio.run but does not
2 participants