Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

dev server sets wrong HTTP_HOST when path starts with a double slash #822

Closed
ThiefMaster opened this issue Dec 6, 2015 · 5 comments
Closed

dev server sets wrong HTTP_HOST when path starts with a double slash #822

ThiefMaster opened this issue Dec 6, 2015 · 5 comments
Assignees
@untitaker
Labels
bug

Comments

@ThiefMaster
Copy link
Member

See pallets/flask#1639 (comment)

if request_url.netloc:
    environ['HTTP_HOST'] = request_url.netloc

This code was added in 7486573 / #248. Do absolute http requests even make sense except for HTTP proxies?
@davidism davidism mentioned this issue Dec 6, 2015
Closed
@davidism
Copy link
Member

davidism commented Dec 6, 2015

As reported in the linked issue, this can lead to weird behavior. http://127.0.0.1:5000//google.com will redirect to Google.

@mitsuhiko
Copy link
Contributor

That should definitely be fixed.

@untitaker
Copy link
Contributor

Perhaps just change if request_url.netloc to if request_url.scheme and request_url.netloc.

@untitaker
Copy link
Contributor

Triaging: blocker bug

@ThiefMaster ThiefMaster mentioned this issue Apr 10, 2016
Closed
untitaker added a commit that referenced this issue Apr 10, 2016
@untitaker
Add testcase for #822
ad5716f
untitaker added a commit that referenced this issue Apr 10, 2016
@untitaker
serving: absolute request URLs need a scheme
27f3839 
Fix #822
@untitaker untitaker mentioned this issue Apr 10, 2016
Closed
@untitaker untitaker self-assigned this Apr 10, 2016
@untitaker
Copy link
Contributor

Could somebody review #890 and check if I missed something?

untitaker added a commit that referenced this issue Apr 10, 2016
@untitaker
Add testcase for #822
63c46f2
untitaker added a commit that referenced this issue Apr 10, 2016
@untitaker
serving: absolute request URLs need a scheme
a93c592 
Fix #822
untitaker added a commit that referenced this issue Apr 10, 2016
@untitaker
serving: absolute request URLs need a scheme
ca7183b 
Fix #822
untitaker added a commit that referenced this issue Apr 10, 2016
@untitaker
Add testcase for #822
064f101
untitaker added a commit that referenced this issue Apr 10, 2016
@untitaker
serving: absolute request URLs need a scheme
e9ff063 
Fix #822
untitaker added a commit that referenced this issue Apr 14, 2016
@untitaker
Add testcase for #822
abbbf9a
untitaker added a commit that referenced this issue Apr 14, 2016
@untitaker
Merge pull request #891 from pallets/double-slash-path
556bdcb 
Fix #822
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@untitaker untitaker

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

serving: absolute request URLs need a scheme pallets/werkzeug
4 participants
@mitsuhiko @ThiefMaster @untitaker @davidism