-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add gravity nonce #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byte-bandit
commented
May 28, 2024
byte-bandit
commented
May 28, 2024
byte-bandit
commented
May 28, 2024
@webelf101 I have no idea how to get the tests running for this, I've updated |
webelf101
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The test was built using brownie framework but it isn't updated anymore so the test will fail. We may need to rebuild tests using apeworx.
1 task
taariq
approved these changes
May 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
Gravity expects atomically incrementing nonces with every event emitted. At the moment, that's not the case, as the emitted
event_id
is shared across different message types. The gravity implementation is a lot more strict that our regular communication channels as in it will enforce aid = id + 1
constraint for every nonce it receives, and will attest to them in order only. This is to ensure correctness of order of funds transferred.This change will also require an update to Pigeon and possibly Paloma in order to populate the constructor properly.