Skip to content

BLD: pandas-wheels are failing #22021

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jreback opened this issue Jul 23, 2018 · 5 comments
Closed

BLD: pandas-wheels are failing #22021

jreback opened this issue Jul 23, 2018 · 5 comments
Labels
Build Library building on various platforms
Milestone
0.24.0

Comments

@jreback
Copy link
Contributor

jreback commented Jul 23, 2018

https://travis-ci.org/MacPython/pandas-wheels/builds/406975380

looks like #21879 somehow broke this. The error messages I think are red herrings for somehow picking up a wrong version of numpy when things are compiled.
@jreback jreback added the Build Library building on various platforms label Jul 23, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 23, 2018
@jreback
Copy link
Contributor Author

jreback commented Jul 23, 2018

@pandas-dev/pandas-core

@TomAugspurger
Copy link
Contributor

Will take a look today.

@TomAugspurger
Copy link
Contributor

Side-note, does anyone know why we use numpy 1.9 for the 3.6 builds as well? Should that be using NumPy 1.11?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jul 23, 2018 •
edited
Loading

The issue seems to be pandas_dtype calling np.dtype with certain arguments.

In [1]: import numpy as np

In [2]: import warnings

In [3]: warnings.simplefilter("always", DeprecationWarning)

Some things are fine,

In [4]: np.dtype(('b', 'c'))
Out[4]: dtype('int8')

others are not

In [5]: np.dtype(('b1', 'b2'))
/Users/taugspurger/miniconda3/envs/pandas-debug/bin/ipython:1: DeprecationWarning: Specified size is invalid for this data type.
Size will be ignored in NumPy 1.7 but may throw an exception in future versions.
  #!/Users/taugspurger/miniconda3/envs/pandas-debug/bin/python
Out[5]: dtype('bool')

We could quickly work around this by just calling doing this inside a warnings filter, but it hints at a deeper problem: we shouldn't be passing data to np.dtype in the first place. E.g. this causes the warning: pd.Index(('b1', 'b2')), which is silly.

This is coming through is_extension_array_dtype (mea culpa).

I'll spend some time today and tomorrow trying to clean this up.

TomAugspurger added a commit to TomAugspurger/pandas that referenced this issue Jul 23, 2018
@TomAugspurger
REF/API: Stricter extension checking.
0a3994b 
Removes is_extension_array_dtype's handling of both arrays and dtypes.
Now it handles just arrays, and we provide `is_extension_dtype` for checking
whether a dtype is an extension dtype. It's the caller's responsibility to know
whether they have an array or dtype.

Closes pandas-dev#22021
@TomAugspurger TomAugspurger mentioned this issue Jul 23, 2018
Merged
@TomAugspurger
Copy link
Contributor

I'm no longer working on this, if someone else wants to.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
0.24.0
Development

No branches or pull requests
2 participants
@jreback @TomAugspurger