-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
np.fix doesn't work #8
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
In principle I agree with you that fill should be renamed to something like fillna or fill_missing since a portion of the NumPy API relies on the fill function. Unfortunately changing it would definitely cause downstream breakage in the next release-- as far as API changes go it's not too terrible to go through and fix client code but it sucks. |
I took a look at fixing this behavior-- I'm going to remove the overridden fill() function from Series, having created fillna functions in all of the classes. There actually is a bug in NumPy which has been fixed about a month ago-- so starting with NumPy 1.6 this can be fixed: |
{Series, DataFrame, WidePanel}.fill have been removed. So np.fix should work on NumPy >= 1.6 (does not work with 1.5.1, though) |
#21401) * ENH: to_sql() add parameter "method" to control insertions method (#8953) * ENH: to_sql() add parameter "method". Fix docstrings (#8953) * ENH: to_sql() add parameter "method". Improve docs based on reviews (#8953) * ENH: to_sql() add parameter "method". Fix unit-test (#8953) * doc clean-up * additional doc clean-up * use dict(zip()) directly * clean up merge * default --> None * Remove stray default * Remove method kwarg * change default to None * test copy insert snippit * print debug * index=False * Add reference to documentation
…ndas-dev#8… (pandas-dev#21401) * ENH: to_sql() add parameter "method" to control insertions method (pandas-dev#8953) * ENH: to_sql() add parameter "method". Fix docstrings (pandas-dev#8953) * ENH: to_sql() add parameter "method". Improve docs based on reviews (pandas-dev#8953) * ENH: to_sql() add parameter "method". Fix unit-test (pandas-dev#8953) * doc clean-up * additional doc clean-up * use dict(zip()) directly * clean up merge * default --> None * Remove stray default * Remove method kwarg * change default to None * test copy insert snippit * print debug * index=False * Add reference to documentation
…ndas-dev#8… (pandas-dev#21401) * ENH: to_sql() add parameter "method" to control insertions method (pandas-dev#8953) * ENH: to_sql() add parameter "method". Fix docstrings (pandas-dev#8953) * ENH: to_sql() add parameter "method". Improve docs based on reviews (pandas-dev#8953) * ENH: to_sql() add parameter "method". Fix unit-test (pandas-dev#8953) * doc clean-up * additional doc clean-up * use dict(zip()) directly * clean up merge * default --> None * Remove stray default * Remove method kwarg * change default to None * test copy insert snippit * print debug * index=False * Add reference to documentation
i think the bigger problem is overriding the default behavior of the fill() method, which may contribute to other numpy / scipy functions not behaving correctly.
The text was updated successfully, but these errors were encountered: