ENH: Allow to_sql to recognize single sql type (GH11886) #13614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
force-pushed
the
pr/13252
branch
from
6dcf00b to
f259a0b
Compare
jorisvandenbossche
force-pushed
the
pr/13252
branch
from
f259a0b to
717606a
Compare
Current coverage is 84.38% (diff: 100%)
|
|
|
||
| """ | ||
| if dtype and not is_dictlike(dtype): |
There was a problem hiding this comment.
use pandas.core.common.is_dict_like (I'll remove this one in a different PR).
jorisvandenbossche
force-pushed
the
pr/13252
branch
from
717606a to
554f7e8
Compare
jorisvandenbossche
force-pushed
the
pr/13252
branch
from
554f7e8 to
e75ea29
Compare
|
lgtm. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of PR #13252
Closes #11886