BLD: fix 2.7_LOCALE build #15540
Closed
BLD: fix 2.7_LOCALE build #15540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplify install_travis.sh, always using a clean miniconda install bump matplotlib to 1.4.0 for _LOCALE, numpy to 1.8.2
|
merging to avoid constant travis failures, but please comment on the question I raised above. |
|
I have no problem with bumping the minimal matplotlib version from 1.2 to > 1.3.1 (1.3 dates from 2013 I think, so we might even go to 1.4? cc @TomAugspurger @sinhrks ). Should probably open a separate issue for that to remind of code clean-up and update of docs. |
|
Ah, I see that in practice > 1.3.1 actually means >= 1.4 (1.4.0 dates from August 2014). But as I said, that sounds good to me to bump to that. |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
simplify install_travis.sh, always using a clean miniconda install bump matplotlib to 1.4.0 for _LOCALE, numpy to 1.8.2 So this removes our testing of mpl 1.2.1 with numpy 1.7.1. We *still* test elsewhere 1.7.1, and mpl 1.3.1 (with 1.8.2) Author: Jeff Reback <jeff@reback.net> Closes pandas-dev#15540 from jreback/build and squashes the following commits: 58b6f2f [Jeff Reback] BLD: fix 2.7_LOCALE build
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify install_travis.sh, always using a clean miniconda install
bump matplotlib to 1.4.0 for _LOCALE, numpy to 1.8.2
So this removes our testing of mpl 1.2.1 with numpy 1.7.1. We still test
elsewhere 1.7.1, and mpl 1.3.1 (with 1.8.2), so I think this is sufficient.
something changed in conda meta data to make the installtion of numpy=1.7.1 / mpl=1.2.1 fail
https://travis-ci.org/jreback/pandas/jobs/206680630
The only question is to we want to 'officially' say that we require mpl >= 1.3.1 ?
Things will still work as long as the installation succeeds, but travis is being problematic.
cc @jorisvandenbossche
cc @tacaswell